Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option -D/--delimiter-special and some wordlists #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

htgoebel
Copy link
Contributor

  • Add option
     -D NUM, --delimiter-special NUM
                          Separate words by NUM special chars (none by default).
  • Add German, Italian and Latin wordlists.

@htgoebel htgoebel changed the title Add option -D/--delimiter-special and some worslists. Add option -D/--delimiter-special and some wordlists Apr 29, 2019
Copy link
Owner

@ulif ulif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hartmut! Thanks a lot for your contribution!

Unfortunately, most of the wordlists from the original world.std.com website are IMHO of minor quality. They are no prefix code and they contain (despite they are not too long) very short words (down to single chars). All this reduces the entropy of passphrases produced with these lists. I therefore avoided to include them in diceware (except the English list from diceware.com).

I'd rather consider to remove the already contained English wordlist as well, as it shares these weaknesses and the EFF list is a major improvement and well done replacement.

I hope you can understand and support this policy. This is also a note to keep you from compiling more wordlists from std.com, as they all seem to suffer from that problems (too short terms, no prefix code).

@htgoebel
Copy link
Contributor Author

Okay, I'll update the pull-request to not include the wordlists anymore.

Also move insert_special_delimiter into a function so it can
be tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants