Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing property for clone node #13

Merged
merged 1 commit into from
Aug 13, 2015
Merged

add missing property for clone node #13

merged 1 commit into from
Aug 13, 2015

Conversation

wuminorb
Copy link

forgot clone ’childPos’ property during clone node

forgot clone ’childPos’ property during clone node
@ulion
Copy link
Owner

ulion commented Jun 11, 2015

What problem this PR try to resolve? any test case?

@wuminorb
Copy link
Author

If you try to use array of 'selectfieldset',missing 'childPos' will cause a bug that you can't select field set correctly. You can test this with JSON below.

{
    schema: {
        "source": {
            "type": "array",
            "items": {
                type: "object",
                "title": "data source",
                "properties": {
                    filename: {
                        type: 'string',
                        title: "filename",

                    },
                    dbaddr: {
                        type: 'string',
                        title: "address of database",

                    },
                    "kind": {
                        "type": "string",
                        "title": "type",
                        "enum": ["excel",
                        "db"]
                    }
                }
            }
        }
    },
    form: [{
        "type": "array",
        "items": {
            "type": "section",
            "items": [{
                "type": "selectfieldset",
                "key": "source[].kind",
                "title": "source",
                "titleMap": {
                    "excel": "Excel",
                    "db": "Database"
                },
                "items": ["source[].filename","source[].dbaddr"]
            },
            ]
        }
    }]
}

ulion added a commit that referenced this pull request Aug 13, 2015
add missing property for clone node
@ulion ulion merged commit 936ad34 into ulion:dev Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants