Move configuration items to app.php

[ctgraham]

Any configuration should be part of the config/app.php.

For example:

lcsu/src/Utility/PhpNetworkLprPrinter.php

Line 21 in fd1e3dc

var $_host="sato1.library.pitt.edu";

lcsu/src/Utility/PhpNetworkLprPrinter.php

Line 84 in fd1e3dc

public function __construct($host="sato1.library.pitt.edu", $port=515) {

Also:

lcsu/src/Auth/EnvAuthenticate.php

Line 97 in fd1e3dc

$username = env('REMOTE_USER', true);

or, remove the option documentation:

lcsu/src/Auth/EnvAuthenticate.php

Lines 45 to 58 in fd1e3dc

	* Available options include stripping a scope of the username, and forcing the
	* username to lowercase.
	* FORCE_LOWERCASE is a boolean
	* DROP_SCOPE will take a boolean, string, or array of strings
	* true will remove all scopes
	* a string or array will remove specific matched scopes
	* ```
	* public $components = array(
	* 'Auth' => array(
	* 'authenticate' => array('EnvAuth.Env' => array(
	* 'FORCE_LOWERCASE' => true,
	* )
	* )
	* );

For any expected configuration in app.php (since it is not captured in version control), add sample configuration in config/app.default.php

[edensung25]

Should I use PHP define or [cakePHP configuration]? (https://book.cakephp.org/3.0/en/development/configuration.html#bootstrapping-cakephp)
Can I put move those parameters into config/Bootstrap.php?

[ctgraham]

These should be done in the cake configuration (config/app.php or an additional included file).

https://book.cakephp.org/3.0/en/development/configuration.html

[ctgraham]

Configuration parameters which are not secure should be set so that the application will work out-of-the-box:

lcsu/config/app.default.php

Lines 387 to 399 in 1a2e45a

	// Define user permission
	'Managers' => 0,
	'Scanners' => 0,
	// Define tray statys
	'Incompleted' => 0,
	'Validate' => 0,
	'Completed' => 0,
	'Exported' => 0,
	// printer configuration
	'HOST' => "**",
	'PORT' => null,

For example, the constants for Managers and Scanners should be 1 and 2.

[edensung25]

updated in commit 1df1cda and 9ff36da

[ctgraham]

Resolved.