common: Remove GNU extension (, ##__VA_ARGS__). #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A zero-length
__VA_ARGS__
would result in a trailing comma, which is a syntax error. GCC supports zero-length__VA_ARGS__
with an extension to eat the comma:, ## __VA_ARGS__
.But this is not standard and since CMakeLists.txt sets
-Wall -Wextra -Wpedantic
, we get a ton of spurious warnings when building with clang:So the function uvgrtp_debug can be implemented as a variadic function (which unlike variadic macros, do support zero-length va_list).