debug: Prepend log macros with UVG_ #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devenvexe
force-pushed
the
mtd/prefix-debug-macros
branch
from
eab1110
to
048a529
Compare
devenvexe
force-pushed
the
mtd/prefix-debug-macros
branch
from
cbe6c42
to
bed81ab
Compare
|
Any chance to get a review on getting this merged? Happy to help how I can. |
jrsnen
reviewed
Aug 15, 2022
include/uvgrtp/debug.hh
Outdated
| #define UVG_LOG_ERROR(...) uvgrtp_debug(LOG_LEVEL_ERROR, __func__, __VA_ARGS__) | ||
| #define UVG_LOG_WARN(...) uvgrtp_debug(LOG_LEVEL_WARN, __func__, __VA_ARGS__) | ||
| #define UVG_LOG_INFO(...) uvgrtp_debug(LOG_LEVEL_INFO, __func__, __VA_ARGS__) | ||
| #define UVG_LOG_DEBUG(...) uvgrtp_debug(LOG_LEVEL_DEBUG, __func__, __VA_ARGS__) |
There was a problem hiding this comment.
Both UVG_LOG_DEBUG should be modified into the LOG_DEBUG on line 66 and 68. This way, debug prints are disabled in release mode.
|
Hi and thank you for this PR. I found a small error in debug.hh, but otherwise looks good. I will probably end up moving debug.hh away from include soon anyway (internal debug prints don't need to be accessible to users of uvgRTP), but this change makes sense anyway. |
|
If you can fix the error, I will merge this. If possible, modify the existing commit, but I will also accept one new commit to fix this. |
devenvexe
force-pushed
the
mtd/prefix-debug-macros
branch
from
bed81ab
to
6620c5a
Compare
|
Thank you I will address |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepend log macros with UVG_ to avoid conflicts with codebase that define their own LOG_* macros