Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic business logic of training a model on a dataset #45

Merged
merged 10 commits into from
Sep 21, 2023
Merged

Conversation

darkodraskovic
Copy link
Collaborator

closes #44

@darkodraskovic darkodraskovic added the feature introducing new functionality label Sep 18, 2023
@darkodraskovic darkodraskovic added this to the Basic business logic milestone Sep 18, 2023
@darkodraskovic darkodraskovic self-assigned this Sep 18, 2023
…ng a model

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
agent/service.go Outdated
// Construct the Python script content with CSV data as a command-line argument
script := string(algoContent)
data := string(dataContent)
socketPath := "unix_socket"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to put this file descriptor in some part of the file-system that is guaranteed to be in RAM - like for example in /tmp.

Of course, verify previously that in our Linux config (fstab or similar) /tmp is mounted over tmpfs in RAM.

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 1c30899 into main Sep 21, 2023
1 of 2 checks passed
darkodraskovic pushed a commit that referenced this pull request Sep 21, 2023
Add basic business logic of training a model on a dataset
@darkodraskovic darkodraskovic deleted the algo_data branch September 21, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature introducing new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basic business logic of training a model on a dataset and returning a model
2 participants