Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle bidirectional operator #80

Merged
merged 1 commit into from
Jun 5, 2019
Merged

feat: handle bidirectional operator #80

merged 1 commit into from
Jun 5, 2019

Conversation

thoas
Copy link
Member

@thoas thoas commented Jun 5, 2019

No description provided.

@thoas thoas requested a review from novln June 5, 2019 09:26
novln
novln reviewed Jun 5, 2019
View reviewed changes
builder/builder_test.go Outdated Show resolved Hide resolved
@novln
Copy link
Collaborator

novln commented Jun 5, 2019

It would be great to add Overlap for stmt.Value in tests.
And also, to add Contains, IsContainedBy and Overlap for stmt.Identifier.

@thoas thoas requested a review from novln June 5, 2019 09:55
novln
novln approved these changes Jun 5, 2019
View reviewed changes
Copy link
Collaborator

@novln novln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍
Thx you.

@thoas thoas merged commit 7ed4e94 into master Jun 5, 2019
@thoas thoas deleted the feat/values branch June 5, 2019 10:01
@novln novln mentioned this pull request Jun 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novln novln novln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thoas @novln