Add "default_room" to profile settings #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjajaja
force-pushed
the
default_room_2
branch
from
2c6c5a2
to
4e92bc4
Compare
ulyssa
added a commit
to benjajaja/iamb
that referenced
this pull request
Jan 28, 2023
ulyssa
force-pushed
the
default_room_2
branch
from
4e92bc4
to
bdf500f
Compare
ulyssa
force-pushed
the
default_room_2
branch
from
bdf500f
to
4337be1
Compare
ulyssa
changed the title
|
I fixed an issue with the tests, and added the PR number to the commit message. Once the CI finishes, I'll merge it and cut a release. |
Closed
|
Oh I should have run the tests 🤦♂️ thanks for fixing it! |
|
I've just published v0.0.4. Thank you for the change! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joined on start if set.
I first tried with
OwnedRoom::try_from: e80b86b#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcR136, but I guessIambWindow::findis more flexible.