Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nix flake #73

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Add Nix flake #73

merged 1 commit into from
Mar 31, 2023

Conversation

benjajaja
Copy link
Contributor

Since it's a flake, it should rely on Cargo.lock and not require maintenance, except when a new system dependency is added, which is rare with cargo. Currently the only ones are openssl and pkg-config.

@ulyssa
Copy link
Owner

ulyssa commented Mar 29, 2023

Thanks for adding this!

Is there a reason to use pkgs.rust-bin.nightly."2023-03-17".default over pkgs.rust-bin.stable.latest.default like you had it initially? I don't know much about Nix, but I would assume that stable would update automatically over time, right?

@benjajaja
Copy link
Contributor Author

The reason was that .rs files are formatted with rust-fmt of nightly. Or at least that's what's happening with my nvim+lsp+rust installation. Also perhaps iamb used to require nightly to build some time ago? I don't remember exactly.

Anyway, yay iamb builds against stable, changed that, but only left nightly for the devShell feature. The devShell is pinned to some random recent nightly build so that it caches and doesn't recreate a new derivation every day when a new nightly comes out.

@ulyssa ulyssa changed the title nix flake Add Nix flake Mar 31, 2023
@ulyssa
Copy link
Owner

ulyssa commented Mar 31, 2023

Ah, that makes sense. Yeah, you'd need a nightly build for rust-fmt.

I've merged this into main. Thanks for adding this! :) I'll update the website to mention it when I do the next release.

@meain
Copy link

meain commented Jul 14, 2023

FYI, I'm maintaining it in nixpkgs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants