Brian/uc 35 merge tables ch #1515
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for heartfelt-souffle-72e1df failed.
|
| arr.push(`and ${table}.${key}=$${params.length + 1}`); | ||
| params.push(decodeURIComponent(filter)); | ||
| } | ||
| arr.push(`and ${key}=$${params.length + 1}`); |
There was a problem hiding this comment.
If this is all same logic as above, they should be combined.
lib/session.js
Outdated
| @@ -31,11 +34,11 @@ export async function getSession(req) { | |||
| let websiteId = null; | |||
|
|
|||
| // Check if website exists | |||
| if (redis.client) { | |||
| if (isRedis) { | |||
There was a problem hiding this comment.
This makes less sense. If "we have a redis client" vs "we are a redis?"
There was a problem hiding this comment.
updated language.
| created_at: getDateFormat(new Date()), | ||
| url: url?.substring(0, URL_LENGTH), | ||
| event_name: event_name?.substring(0, EVENT_NAME_LENGTH), | ||
| event_data: JSON.stringify(event_data), | ||
| ...sessionArgs, |
There was a problem hiding this comment.
we pass the entire session object now, where sessionArgs is the rest of the session data ( hostname, browser, os, device, language). Country is the only property that needs special care.
| ${column !== 'event_name' ? `and event_name = ''` : ''} | ||
| and ${getBetweenDates('created_at', startDate, endDate)} | ||
| ${pageviewQuery} | ||
| ${sessionQuery} |
There was a problem hiding this comment.
How does this work without knowing you need to join session?
There was a problem hiding this comment.
joinSession only needs to occur if data is collected outside of the primary table being collected on. Now that everything is merged into 1 table, a join never needs to occur.
Merge session/pageview/event for CH database.