Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix account delete bug #1627

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix account delete bug #1627

merged 1 commit into from
Nov 1, 2022

Conversation

briancao
Copy link
Collaborator

@briancao briancao commented Nov 1, 2022

fix requestor account being deleted

@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
umami ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 1:53AM (UTC)

@mikecao mikecao merged commit 1c69577 into app Nov 1, 2022
@mikecao mikecao deleted the bug/um-92-delete-account branch November 1, 2022 03:05
@@ -53,11 +53,15 @@ export default async (req, res) => {
}

if (req.method === 'DELETE') {
if (id === userId) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request passes through because of IsStrictlyEqual
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants