Issue where key is found in word resolved. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedSiddiqui
commented
Jun 4, 2016
MohammedSiddiqui
commented
- Used regex and .replace function on string instead of .split and .join.
- Created a basic test case to verify if this works.
two test cases are added to verify my work. The Object test case was repeated twice, hence removed. Basic ESLint fix.
used es6 template interpolation in expression
|
I have couple of issues with this PR. First thing is that you don't commit any experimental stuff in the repository. Commits [64c6ef3] and [3dc79d7] are not required for this change. Secondly, unit tests. You don't add a describe block for one edge case. You add tests for any corner case in the already added blocks for the sake of consistency. I'm closing this off in favor of #5. I have tweaked your changes to get the desired result. Moreover, I have added more unit tests. Kudos for your work. |
|
Understood, thank you for your feedback ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.