Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Render calculated user start nodes in User Workspace #2010

Merged
merged 17 commits into from
Jun 26, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jun 18, 2024

Description

This PR implements the new endpoint to fetch the calculated start nodes for a user (umbraco/Umbraco-CMS#16609)

What to test:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen changed the title Bugfix: Calculate user start nodes Bugfix: Render calculated user start nodes in User Workspace Jun 18, 2024
@madsrasmussen madsrasmussen marked this pull request as ready for review June 18, 2024 13:09
@iOvergaard iOvergaard self-requested a review June 26, 2024 08:17
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and tests good. I tried several scenarios with varying degrees of start nodes. The only thing I could find is that you have to click out of the user and back into them when you change their user groups to get the UI to call the "calculate-start-nodes" endpoint again. Perhaps we could listen on that when user groups change. Approved nonetheless!

@iOvergaard iOvergaard merged commit 985975f into main Jun 26, 2024
6 checks passed
@iOvergaard iOvergaard deleted the 14/bugfix/calculate-user-start-nodes branch June 26, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants