Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint linebreak on windows #2099

Merged
merged 1 commit into from
Jul 5, 2024
Merged

ESLint linebreak on windows #2099

merged 1 commit into from
Jul 5, 2024

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Jul 5, 2024 •
edited
Loading

Description

Eslint is complaining a lot on windows now.
Changing to warn and allowing linebreaks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Example on windows without the changes:

image

after
image

@loivsen loivsen requested a review from iOvergaard July 5, 2024 09:45
@iOvergaard iOvergaard enabled auto-merge July 5, 2024 09:47
@iOvergaard iOvergaard added ignore-for-release Pull requests that will not be included in the automated release notes. internal Changes that do not affect the runtime files, e.g. changes to the build setup labels Jul 5, 2024
@iOvergaard iOvergaard merged commit 268d57a into main Jul 5, 2024
8 checks passed
@iOvergaard iOvergaard deleted the v14/chore/eslint-linebreaks-on-windows branch July 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
ignore-for-release Pull requests that will not be included in the automated release notes. internal Changes that do not affect the runtime files, e.g. changes to the build setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loivsen @iOvergaard