Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: UFM review, fixes and amends #2139

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Conversation

leekelleher
Copy link
Member

Description

Review of UFM code, made fixes and amends, includes...

  • Introduces UfmToken interface type, so to no longer expose Marked library's Tokens.Generic.
    • This isn't a breaking-change, as UfmToken extends Tokens.Generic, which itself was an extendable interface.
  • Adds tests for parsing the UFM syntax
  • Simplified the UFM regular expression; also handles whitespace better.
  • For Collection Views (Table and Grid), wraps the value in an object property, e.g. { value }.
    • So that accessing the value it works similar to v13 ListView. UFM syntax is now {=value}.
  • Loosened the rendering in <ufm-label-value> so that non-undefined falsy values can be rendered.

Fixes umbraco/Umbraco-CMS#16776.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How to test?

General testing for dynamic labels in Collection Views, Block List/Grid and Document property descriptions.

Copy link

sonarcloud bot commented Jul 25, 2024

@leekelleher leekelleher enabled auto-merge (rebase) July 25, 2024 09:22
@leekelleher leekelleher merged commit e629920 into main Jul 25, 2024
9 checks passed
@leekelleher leekelleher deleted the v14/bugfix/ufm-amends branch July 25, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Umbraco Flavored Markdown
3 participants