Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for manually exchange an authorization code for a token #203

Merged

Conversation

acoumb
Copy link
Contributor

@acoumb acoumb commented Jul 30, 2024

Current PR adds a feature to the HubSpot Forms integration that allow users to manually exchange an authorization code for an access token.

A particular use case has created an issue during the OAuth2 flow. When connecting to the service without having any cookie credentials of that service, the browser removes the window.opener property resulting in the authorization window not closing and an inability to retrieve the access token.

To address this, we are watching the window for 7 seconds, and if it remains open, we are displaying an input field allowing users to exchange the authorization code for an access token.

A small demo here.

Next steps will be to apply the same change to Dynamics and Google.

@acoumb acoumb requested a review from AndyButland July 30, 2024 15:19
@acoumb acoumb merged commit d319617 into main Jul 31, 2024
13 checks passed
@acoumb acoumb deleted the feature/manually-exchange-authorization-code-for-access-token branch July 31, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants