Skip to content

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Aug 2, 2022

Description

Added padding variable to button top/bottom
The padding is removed on compact buttons

Added story for multi line buttons

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. Would you also try and add generics to the uui-button story to allow us to have type-checking of props?

Example:

export default {...} as Meta<UUIButtonElement>;

const Template = Story<UUIButtonElement>...;

You only need to do so on the first story since all others inherit from that.

@iOvergaard iOvergaard merged commit d264e73 into v1/dev Aug 5, 2022
@iOvergaard iOvergaard deleted the feature/button-multiline branch August 5, 2022 09:54
@iOvergaard iOvergaard added the documentation Improvements or additions to documentation label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants