uui-input-file => Only show add button when multiple or no file selected #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only show add button when multiple or no file selected
iOvergaard
requested changes
Jan 27, 2023
There was a problem hiding this comment.
Hi @nathanwoulfe
I think you might be right here, but something's happened with Storybook, where the story for a prevalue doesn't look right anymore (it should show the selected image). Also, the build is failing because of linting issues :-)
|
Heya @iOvergaard, should be better now - was missing an import, which broke the story. |
iOvergaard
added
enhancement
iOvergaard
approved these changes
Jan 30, 2023
iOvergaard
added a commit
that referenced
this pull request
Apr 20, 2023
…elected (#395) * Update uui-input-file.element.ts Only show add button when multiple or no file selected * missing import --------- Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change updates uui-input-file to only show the add button only when multiple is true, or when no files are selected (single-file mode).
Types of changes
Motivation and context
The picker works correctly in it's current shape (ie single mode only allows one file, multiple allows many), I'm just not sure the UI makes sense - continuing to display the Add button after selecting a file in single mode is potentially confusing, even though the button will replace the existing selection.
Alternatively could consider changing the button text when a file is selected in single-mode (ie
ReplaceorChange selectionor something similar)I won't lose a minute of sleep if the current implementation is preferred.
How to test?
Screenshots (if appropriate)
Checklist