Skip to content

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Apr 4, 2024

Description

This PR adds a --uui-button-transition custom property to #button selector so you can set a transition on the button properties if you want to (closes #764 )
It also cleans up some unused code and adds styling for :focus-visible pseudoclass ( closes #749 ). See image below.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

github-actions bot commented Apr 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-771.westeurope.azurestaticapps.net

@julczka julczka marked this pull request as ready for review April 4, 2024 08:48
Copy link

github-actions bot commented Apr 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-771.westeurope.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Apr 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-771.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the enhancement New feature or request label Apr 5, 2024
@iOvergaard iOvergaard merged commit da9151a into v1/contrib Apr 5, 2024
@iOvergaard iOvergaard deleted the feature/transition-on-uui-button branch April 5, 2024 13:33
@iOvergaard iOvergaard changed the title Feature/transition-on-uui-button feat(uui-button): add transition property Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support transition on uui-button :focus-visible state hardly visible on uui-button element with color="primary"
2 participants