Address full object request corner case and resolve file format extension #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higher abstraction level so that potentially all storage backends can benefit from it. Co-authored-by: @mmalenic
…ole file bigger than 4294967295 bytes, we'd have a problem. This still doesn't fix the egressing of bytes when the response should be a few bytes JSON with the whole start-end byterange of a big S3 object [ci skip]
…with the full range
brainstorm
changed the title
|
Closed, as this is addressed in #107. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @victorskl for reporting this issue, it exposes a few areas that need improvement, namely this excessive fetching in the AWS backend.
How to reproduce
I will address the failing tests next, but with these changes @victorskl would be able to get htsget-rs to not block on big files (114G) on the reproducer we discussed.