-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme and Refactor Pipeline Code #157
Conversation
Did mention to switch the Parent of the microservice stack to a regular class to give a shorter stack name From : But in order to do that the class should be free from any resource lookup which we are using it here for shared resources. Maybe we could delay this for now? |
RE: switch to a regular class & stack name long
Yes, pls. This is fine at this point. Either way, it only reduces one step in the Stack path. And we will be doing |
I will review the PR on Monday, eta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Will.!
This will PR will require to cdk deploy the pipeline as the makefile command will change. Will merge this after #155 |
Got it, merging the other one. |
resolution: "aws-cdk-lib@npm:2.132.1" | ||
"aws-cdk-lib@npm:^2.133.0": | ||
version: 2.133.0 | ||
resolution: "aws-cdk-lib@npm:2.133.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @alexiswl @brainstorm for the change that shorten the yarn-cdk command
|
yarn cdk
syntax fromyarn cdk-stateless-pipeline
->yarn cdk-stateless
, the pipeline should just be the stackmake suite
->make test-suite
which only test microservice testsbin/orcabus.ts
, alternative to deploy directly from local is fromyarn cdk-stateless deploy {theBetaStack}
Fix #150
Could be merged after #155