Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Cleanup Peggo #2

Closed
10 of 13 tasks
alexanderbez opened this issue Oct 25, 2021 · 0 comments
Closed
10 of 13 tasks

Chore: Cleanup Peggo #2

alexanderbez opened this issue Oct 25, 2021 · 0 comments
Assignees

Comments

@alexanderbez
Copy link

alexanderbez commented Oct 25, 2021

A braindump of changes I'd like to see in Peggo:

  • Update README
  • Remove dependencies on github.com/InjectiveLabs/sdk-go
  • Remove metrics usage (we can replace this with prom later)
  • Remove statsd usage
  • Replace CLI framework with cobra (chore: refactor CLI framework #3)
  • Migrate commands from DNM: peggy contract tools umee#177
  • User zerolog logger instead of current logger
  • Groom for idiomatic logging (e.g. proper formatting, grammar, capitalization, etc...)
  • Remove hard-coded references to injective
  • Remove all fmt.Println() in favor of fmt.Fprint* for non-logger diagnostic output
  • Remove all errors.Wrap(...) in favor of fmt.Errorf("...: %w", err)
  • Fix all golangci-lint errors (per $ make lint)
  • Examine Orchestrator implementation
    • Do we need to use an interface?
    • Are there methods or functions we can cleanup or remove?
    • etc...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants