Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(did-you-know): beautify link #10462

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

AkaraChen
Copy link
Member

@AkaraChen AkaraChen commented Feb 9, 2023

image
现在这样子不太好看。
修改后 IDE 也能正常识别链接
image

@vercel
Copy link

vercel bot commented Feb 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
umi ⬜️ Ignored (Inspect) Feb 9, 2023 at 8:54AM (UTC)

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 29.61% // Head: 29.61% // No change to project coverage 👍

Coverage data is based on head (f26a887) compared to base (73ffe37).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10462   +/-   ##
=======================================
  Coverage   29.61%   29.61%           
=======================================
  Files         446      446           
  Lines       13040    13040           
  Branches     3075     3075           
=======================================
  Hits         3862     3862           
  Misses       8535     8535           
  Partials      643      643           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit f87173f into umijs:master Feb 9, 2023
@fz6m
Copy link
Contributor

fz6m commented Feb 9, 2023

后面可以考虑照搬这个 terminal-link 的脚本,支持 link 的话就进一步精简链接,不支持的话 fallback 到原来的打印 url 逻辑。

@AkaraChen
Copy link
Member Author

AkaraChen commented Feb 10, 2023

后面可以考虑照搬这个 terminal-link 的脚本,支持 link 的话就进一步精简链接,不支持的话 fallback 到原来的打印 url 逻辑。

我有几点不太明白,这个 terminal-link 我看了一下依赖关系,总共依赖了五个包(包括依赖的依赖),都是下载量千万级的,而且贡献者列表里都有 sindresorhus,我觉得算是可信的依赖,做个 prebundle 好像就差不多了,如果需要照搬是出于什么考量呢?

我已经用 father prebundle 了这个包,虽然 dts 生成不正常,但是其他部分是正常的,打印的效果是这样的,文案上我想听一下你们的意见
image

@fz6m
Copy link
Contributor

fz6m commented Feb 10, 2023

是的,我看了下,只需要预打包下,然后自定义一下 fallback 文本就行了,不需要自己 fork 。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants