Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use appData umiName in command line info #12017

Merged
merged 1 commit into from
Dec 31, 2023
Merged

feat: use appData umiName in command line info #12017

merged 1 commit into from
Dec 31, 2023

Conversation

chiaweilee
Copy link
Member

before:
Screenshot 2023-12-30 at 19 40 59

afther:
Screenshot 2023-12-30 at 19 43 40

Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2023 11:47am

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7385a87) 28.77% compared to head (6f6c71b) 28.77%.

Files Patch % Lines
packages/preset-umi/src/commands/build.ts 0.00% 1 Missing ⚠️
packages/preset-umi/src/commands/dev/dev.ts 0.00% 1 Missing ⚠️
packages/preset-umi/src/commands/mfsu/util.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12017   +/-   ##
=======================================
  Coverage   28.77%   28.77%           
=======================================
  Files         489      489           
  Lines       14962    14962           
  Branches     3554     3554           
=======================================
  Hits         4305     4305           
  Misses       9891     9891           
  Partials      766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fz6m fz6m merged commit 1b43e14 into umijs:master Dec 31, 2023
23 checks passed
@sorrycc
Copy link
Member

sorrycc commented Jan 15, 2024

image 会影响这个,我 revert 下。

@fz6m
Copy link
Contributor

fz6m commented Jan 16, 2024

看起来好像大家更希望展示 umi 的版本号。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants