Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default build absolute path #2449

Closed
wants to merge 1 commit into from
Closed

fix: default build absolute path #2449

wants to merge 1 commit into from

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented May 21, 2019 •
edited

默认不 build 绝对路径，像 babel-plugin-import 升级 umi-tools 后，不去掉 pkg 中的 babel，就会 build 出绝对路径。

image

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@coveralls
Copy link

coveralls commented May 21, 2019 •
edited

Pull Request Test Coverage Report for Build 3678

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 36.028%
Files with Coverage Reduction New Missed Lines %
packages/babel-preset-umi/src/index.js 1 0.0%
Totals Coverage Status
Change from base Build 3676: 0.0%
Covered Lines: 1421
Relevant Lines: 3952
💛 - Coveralls

@sorrycc
Copy link
Member

sorrycc commented May 22, 2019

绝对路径有什么问题？absoluteRuntime 是为了解决 babel 依赖升级不可控的问题。

@ycjcl868
Copy link
Contributor Author

统一走 umi-library

@ycjcl868 ycjcl868 closed this May 22, 2019
@ycjcl868 ycjcl868 deleted the fix-babel-preset-umi branch May 22, 2019 04:11
@weekly-digest weekly-digest bot mentioned this pull request May 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg(babel-preset-umi)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ycjcl868 @coveralls @sorrycc