Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve test coverage #3217

Merged
merged 10 commits into from
Sep 18, 2019
Merged

chore: improve test coverage #3217

merged 10 commits into from
Sep 18, 2019

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Sep 17, 2019

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@netlify
Copy link

netlify bot commented Sep 17, 2019 •
edited
Loading

Deploy preview for umijs ready!

Built with commit 9995bc5

https://deploy-preview-3217--umijs.netlify.com

@sorrycc sorrycc force-pushed the chore/improve-test-coverage-0917 branch from 0b64db2 to 868dc00 Compare September 17, 2019 07:41
@coveralls
Copy link

coveralls commented Sep 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 6535

  • 30 of 50 (60.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.4%) to 41.569%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/af-webpack/src/build.js 0 1 0.0%
packages/umi-mock/src/createMiddleware.js 9 10 90.0%
packages/af-webpack/src/getWebpackConfig/index.js 9 11 81.82%
packages/af-webpack/src/getUserConfig/index.js 2 18 11.11%
Totals Coverage Status
Change from base Build 6512: 5.4%
Covered Lines: 4372
Relevant Lines: 10454
💛 - Coveralls

@sorrycc sorrycc force-pushed the chore/improve-test-coverage-0917 branch from 528bb5e to b82ed28 Compare September 18, 2019 05:25
@sorrycc sorrycc merged commit 9f2aaf0 into master Sep 18, 2019
@sorrycc sorrycc deleted the chore/improve-test-coverage-0917 branch September 18, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr(chore)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorrycc @coveralls