Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr perf #3696

Merged
merged 2 commits into from
Nov 25, 2019
Merged

fix: ssr perf #3696

merged 2 commits into from
Nov 25, 2019

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Nov 24, 2019

Close umijs/umi-server#35.

  • getInitialProps 函数内建议使用 return,不然会直接返回整个 model
  • 优化 serialize-javascript ,只 require 一次。
Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@label-actions
Copy link

label-actions bot commented Nov 24, 2019

@ycjcl868 请看下。

@netlify
Copy link

netlify bot commented Nov 24, 2019

Deploy preview for pro-pre-umijs failed.

Built with commit afa80f4

https://app.netlify.com/sites/pro-pre-umijs/deploys/5ddab1d4ede1940008111e70

@codecov
Copy link

codecov bot commented Nov 24, 2019

Codecov Report

Merging #3696 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3696   +/-   ##
=======================================
  Coverage   40.38%   40.38%           
=======================================
  Files         283      283           
  Lines        7956     7956           
  Branches     1865     1915   +50     
=======================================
  Hits         3213     3213           
+ Misses       4366     4360    -6     
- Partials      377      383    +6
Impacted Files Coverage Δ
packages/umi-build-dev/src/FilesGenerator.js 1.5% <ø> (ø) ⬆️
packages/umi-plugin-react/src/plugins/antd.js 0% <0%> (ø) ⬆️
...kages/umi-plugin-ui/src/plugins/dashboard/index.ts 0% <0%> (ø) ⬆️
...s/umi-build-dev/src/plugins/commands/block/util.ts 33.11% <0%> (ø) ⬆️
packages/umi-plugin-ui/src/bubble/index.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2670f...afa80f4. Read the comment docs.

@ycjcl868 ycjcl868 changed the title fix: ssr perf, antd on demand loading fix: ssr perf Nov 24, 2019
@sorrycc sorrycc merged commit d39fca9 into master Nov 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-ssr-perf branch November 25, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants