Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast): getExportProps() supports more common export syntax #4354

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Conversation

imhele
Copy link
Contributor

@imhele imhele commented Apr 1, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • support for extracting functions declaration from export
  • support for extracting directly exported values

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #4354 into master will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4354      +/-   ##
==========================================
+ Coverage   82.63%   82.94%   +0.30%     
==========================================
  Files         138      138              
  Lines        2724     2773      +49     
  Branches      686      695       +9     
==========================================
+ Hits         2251     2300      +49     
  Misses        464      464              
  Partials        9        9              
Impacted Files Coverage Δ
packages/ast/src/getExportProps/getExportProps.ts 100.00% <100.00%> (ø)
...ackages/ast/src/getExportProps/propertyResolver.ts 100.00% <100.00%> (ø)
packages/core/src/Route/getConventionalRoutes.ts 98.83% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03a5a9...1a83ff7. Read the comment docs.

@sorrycc sorrycc merged commit b863d2b into master Apr 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the ast branch April 1, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants