Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ts-ignore for defineConfig.d.ts #4613

Merged
merged 1 commit into from May 7, 2020

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 7, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • 为 defineConfig.d.ts 添加 ts-ignore,避免依赖 umi 时的 tsc 报错

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #4613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4613   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files         144      144           
  Lines        2908     2908           
  Branches      728      728           
=======================================
  Hits         2408     2408           
+ Misses        492      491    -1     
- Partials        8        9    +1     
Impacted Files Coverage Δ
packages/core/src/Config/Config.ts 61.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd19fd7...22508c9. Read the comment docs.

@sorrycc sorrycc merged commit 1dfdfe9 into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/add-ts-ignore-for-define-config branch May 7, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant