New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: renderClient with callback #4979
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4979 +/- ##
==========================================
+ Coverage 82.84% 83.06% +0.21%
==========================================
Files 153 153
Lines 3381 3383 +2
Branches 888 904 +16
==========================================
+ Hits 2801 2810 +9
+ Misses 573 565 -8
- Partials 7 8 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
插件里怎么用? |
会执行,compose 好像是依次执行 |
看写法应该不会,加个用例试试。 |
确实会有这个问题,oldRender 如果不是 render 插件列表模板的那个,是拿不到这个入参的,除非这么改一下 20addc3#diff-769d306c38234a69b1fb8eb7bad75b92R23 |
/rebase |
验证 ok,可以用,我 merge 下 master |
return renderClient({ | ||
...opts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
跟 https://github.com/umijs/umi/pull/5067/files 里的变更好像重复了
...opts 挪到最下面?相对于允许覆盖默认配置
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议覆盖默认的值,...opts
问题排查起来比较麻烦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For umijs/plugins#293
Checklist
npm test
passesDescription of change