Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair routing redirection without components #505

Merged
merged 3 commits into from
May 21, 2018
Merged

Repair routing redirection without components #505

merged 3 commits into from
May 21, 2018

Conversation

xiaohuoni
Copy link
Member

Close #483

@coveralls
Copy link

coveralls commented May 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 451

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 21.432%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-plugin-dva/src/index.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi-plugin-dva/src/index.js 1 26.71%
Totals Coverage Status
Change from base Build 450: -0.02%
Covered Lines: 479
Relevant Lines: 2455
💛 - Coveralls

@sorrycc sorrycc merged commit ff5c214 into umijs:master May 21, 2018
@xiaohuoni xiaohuoni mentioned this pull request May 25, 2018
Closed
sorrycc pushed a commit that referenced this pull request Jun 23, 2022
@stormslowly @sorrycc
优化 generators (#505)
ba02d22 
* refactor: 🎨 extract Generator helper to avoid duplication

* refactor: 🎨 dva generator refactory using helper

* refactor: 🎨 refactory with helper

* refactor: 🎨 refactory jest prettier tsconfig with helper

* feat: ✨ add use local packjson for umijs/plugin install version

* refactor: 🎨 get umijs plugin version for dev dependence

* refactor: 🎨 add ts,ts-node for jest.config.ts

Co-authored-by: pshu <pishu.spf@antfin.com>
xierenyuan pushed a commit to xierenyuan/umi that referenced this pull request Jun 23, 2022
@stormslowly
优化 generators (umijs#505)
c0179ff 
* refactor: 🎨 extract Generator helper to avoid duplication

* refactor: 🎨 dva generator refactory using helper

* refactor: 🎨 refactory with helper

* refactor: 🎨 refactory jest prettier tsconfig with helper

* feat: ✨ add use local packjson for umijs/plugin install version

* refactor: 🎨 get umijs plugin version for dev dependence

* refactor: 🎨 add ts,ts-node for jest.config.ts

Co-authored-by: pshu <pishu.spf@antfin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type(bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaohuoni @coveralls @sorrycc