Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import from lost dep will cause 100% cpu #526

Merged
merged 1 commit into from
May 22, 2018
Merged

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 22, 2018

ref: #521


依赖一个不存在的模块时,会导致 cpu 100%+,原因是 https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js 这个插件引起的,cnpm/tnpm 下明显会卡,yarn 有一点感觉,但不明显,create-react-app 也有这个问题,但他们用 yarn,所以不明显(换成 cnpm/tnpm 安装就很明显了)。

@sorrycc sorrycc merged commit f322bb5 into master May 22, 2018
@sorrycc sorrycc deleted the fix/lost-dep-100-cpu branch May 22, 2018 23:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 463

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 21.586%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/UserConfig.js 2 3 66.67%
Totals Coverage Status
Change from base Build 461: 0.03%
Covered Lines: 484
Relevant Lines: 2473

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 463

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 21.586%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/UserConfig.js 2 3 66.67%
Totals Coverage Status
Change from base Build 461: 0.03%
Covered Lines: 484
Relevant Lines: 2473

💛 - Coveralls

sorrycc added a commit that referenced this pull request Jun 23, 2022
* feat(core): pluginAPI registerPresets plugin type correction

* fix(preset-umi): dev data.changes ConfigChangeType specify error

* feat(preset-umi): tmpFiles exports plugins types.d.ts remove suffix

* Update packages/preset-umi/src/features/tmpFiles/tmpFiles.ts

* Update packages/preset-umi/src/features/tmpFiles/tmpFiles.ts

* feat(bundler-webpack): depConfig add mfsu.chainWebpack

* docs(config): mfsu add chainWebpack introduction

* Update docs/docs/api/config.md

Co-authored-by: xierenhong <xierenhong@kuaishou.com>
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
xierenyuan added a commit to xierenyuan/umi that referenced this pull request Jun 23, 2022
* feat(core): pluginAPI registerPresets plugin type correction

* fix(preset-umi): dev data.changes ConfigChangeType specify error

* feat(preset-umi): tmpFiles exports plugins types.d.ts remove suffix

* Update packages/preset-umi/src/features/tmpFiles/tmpFiles.ts

* Update packages/preset-umi/src/features/tmpFiles/tmpFiles.ts

* feat(bundler-webpack): depConfig add mfsu.chainWebpack

* docs(config): mfsu add chainWebpack introduction

* Update docs/docs/api/config.md

Co-authored-by: xierenhong <xierenhong@kuaishou.com>
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants