Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default 404 plugin for convention-routing #5349

Closed
wants to merge 2 commits into from
Closed

feat: add default 404 plugin for convention-routing #5349

wants to merge 2 commits into from

Conversation

zthxxx
Copy link
Contributor

@zthxxx zthxxx commented Sep 3, 2020 •
edited
Loading

Checklist

  • npm test passes
  • documentation is changed or added
  • commit message follows commit guidelines

Description of change

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 3, 2020

@sorrycc @ycjcl868 麻烦合一下这个修复

umi3 约定式路由 404 的功能一直没加，但官网文档中一直有宣称这个功能；

这个插件在业务中已用了一段时间验证了，希望补齐一下 umi 上游

https://umijs.org/zh-CN/docs/convention-routing#404-%E8%B7%AF%E7%94%B1

image

@ycjcl868
Copy link
Contributor

ycjcl868 commented Sep 3, 2020

ci broken

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 3, 2020

ci broken

@ycjcl868 CI always broken in PRs and commits

image

image

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 3, 2020 •
edited
Loading

@ycjcl868 CI error JavaScript heap out of memory not the bug of this PR

https://app.circleci.com/pipelines/github/umijs/umi/4585/workflows/a993a4ee-028a-4f9b-88be-7fbf8e547eb7/jobs/5284/parallel-runs/0/steps/0-106

image

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 6, 2020

@ycjcl868 remind

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 7, 2020

@sorrycc 麻烦看下有什么问题或者需要修改点

@zthxxx zthxxx mentioned this pull request Sep 7, 2020
Closed
3 tasks
@xiaohuoni
Copy link
Member

看起来是重复的 PR #4987

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 8, 2020

看起来是重复的 PR #4987

@xiaohuoni 本 PR 开头就写了， 4987 的实现有问题，并且这个 bug 也不该用 plugin 解决

@muyiyang1
Copy link

试了一下这个解法 好像在一级目录有问题 我会跳到403

@zthxxx zthxxx closed this Sep 27, 2020
@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 27, 2020 •
edited
Loading

@muyiyang1

replace with #5363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycjcl868 ycjcl868 ycjcl868 left review comments

@sorrycc sorrycc Awaiting requested review from sorrycc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

约定路由 404.js 没有生效
4 participants
@zthxxx @ycjcl868 @xiaohuoni @muyiyang1