Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theme config validate if value is string #617

Merged
merged 1 commit into from
Jun 12, 2018
Merged

fix: theme config validate if value is string #617

merged 1 commit into from
Jun 12, 2018

Conversation

leftstick
Copy link
Contributor

@leftstick leftstick commented Jun 12, 2018

Close #616

As title, i am trying to help on the issue #616. I appreciate if you have time to review my fix.

@coveralls
Copy link

coveralls commented Jun 12, 2018

Pull Request Test Coverage Report for Build 607

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.714%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/UserConfig.js 0 2 0.0%
Totals Coverage Status
Change from base Build 606: 0.0%
Covered Lines: 519
Relevant Lines: 2619

💛 - Coveralls

@sorrycc sorrycc changed the title fix: issue #616. add context while calling validate fix: theme config validate if value is string Jun 12, 2018
@sorrycc sorrycc merged commit 4159591 into umijs:master Jun 12, 2018
sorrycc pushed a commit that referenced this pull request Jun 23, 2022
* fix: plugin-request

* fix: 当 dataField 是 '' 的时候,返回原始值
xierenyuan pushed a commit to xierenyuan/umi that referenced this pull request Jun 23, 2022
* fix: plugin-request

* fix: 当 dataField 是 '' 的时候,返回原始值
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: 配置 theme 校验失败, The "path" argument must be of type string. Received type undefined
3 participants