-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gstreamer v4l2sink support #1
Comments
no longer true! |
Closed
Closed
This was referenced Jan 23, 2019
Closed
Closed
rtg-canonical
added a commit
to rtg-canonical/v4l2loopback
that referenced
this issue
May 27, 2021
Coverity detected an unchecked return code: 1025static int vidioc_s_fmt_out(struct file *file, void *priv, struct v4l2_format *fmt) 1026{ 1027 struct v4l2_loopback_device *dev; 1028 char buf[5]; 1029 int ret; 1. Condition debug > 1, taking true branch. 1030 MARK(); 1031 1032 dev = v4l2loopback_getdevice(file); 1033 ret = vidioc_try_fmt_out(file, priv, fmt); 1034 2. Condition debug > 0, taking true branch. 1035 dprintk("s_fmt_out(%d) %d...%d\n", ret, dev->ready_for_capture, dev->pix_format.sizeimage); 1036 1037 buf[4] = 0; 3. Condition debug > 0, taking true branch. 1038 dprintk("outFOURCC=%s\n", fourcc2str(dev->pix_format.pixelformat, buf)); 1039 4. Condition ret < 0, taking false branch. 1040 if (ret < 0) 1041 return ret; 1042 5. Condition !dev->ready_for_capture, taking true branch. 1043 if (!dev->ready_for_capture) { 1044 dev->buffer_size = PAGE_ALIGN(dev->pix_format.sizeimage); 1045 fmt->fmt.pix.sizeimage = dev->buffer_size; CID 114125 (umlaeute#1 of 1): Unchecked return value (CHECKED_RETURN) 6. check_return: Calling allocate_buffers without checking return value (as is done elsewhere 3 out of 5 times). 1046 allocate_buffers(dev); 1047 } 1048 return ret; 1049} Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
rtg-canonical
added a commit
to rtg-canonical/v4l2loopback
that referenced
this issue
May 27, 2021
Coverity found a possible NULL dereference after NULL check. CID 114122 (umlaeute#1 of 1): Dereference after null check (FORWARD_NULL) 5. var_deref_op: Dereferencing null pointer dev. Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
rtg-canonical
added a commit
to rtg-canonical/v4l2loopback
that referenced
this issue
May 27, 2021
Coverity found a possible NULL dereference after NULL check. CID 114122 (umlaeute#1 of 1): Dereference after null check (FORWARD_NULL) 5. var_deref_op: Dereferencing null pointer dev. Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
umlaeute
pushed a commit
that referenced
this issue
Jun 1, 2021
Coverity detected an unchecked return code: 1025static int vidioc_s_fmt_out(struct file *file, void *priv, struct v4l2_format *fmt) 1026{ 1027 struct v4l2_loopback_device *dev; 1028 char buf[5]; 1029 int ret; 1. Condition debug > 1, taking true branch. 1030 MARK(); 1031 1032 dev = v4l2loopback_getdevice(file); 1033 ret = vidioc_try_fmt_out(file, priv, fmt); 1034 2. Condition debug > 0, taking true branch. 1035 dprintk("s_fmt_out(%d) %d...%d\n", ret, dev->ready_for_capture, dev->pix_format.sizeimage); 1036 1037 buf[4] = 0; 3. Condition debug > 0, taking true branch. 1038 dprintk("outFOURCC=%s\n", fourcc2str(dev->pix_format.pixelformat, buf)); 1039 4. Condition ret < 0, taking false branch. 1040 if (ret < 0) 1041 return ret; 1042 5. Condition !dev->ready_for_capture, taking true branch. 1043 if (!dev->ready_for_capture) { 1044 dev->buffer_size = PAGE_ALIGN(dev->pix_format.sizeimage); 1045 fmt->fmt.pix.sizeimage = dev->buffer_size; CID 114125 (#1 of 1): Unchecked return value (CHECKED_RETURN) 6. check_return: Calling allocate_buffers without checking return value (as is done elsewhere 3 out of 5 times). 1046 allocate_buffers(dev); 1047 } 1048 return ret; 1049} Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
umlaeute
pushed a commit
that referenced
this issue
Jun 1, 2021
Coverity found a possible NULL dereference after NULL check. CID 114122 (#1 of 1): Dereference after null check (FORWARD_NULL) 5. var_deref_op: Dereferencing null pointer dev. Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
umlaeute
pushed a commit
that referenced
this issue
Aug 4, 2022
Coverity detected an unchecked return code: 1025static int vidioc_s_fmt_out(struct file *file, void *priv, struct v4l2_format *fmt) 1026{ 1027 struct v4l2_loopback_device *dev; 1028 char buf[5]; 1029 int ret; 1. Condition debug > 1, taking true branch. 1030 MARK(); 1031 1032 dev = v4l2loopback_getdevice(file); 1033 ret = vidioc_try_fmt_out(file, priv, fmt); 1034 2. Condition debug > 0, taking true branch. 1035 dprintk("s_fmt_out(%d) %d...%d\n", ret, dev->ready_for_capture, dev->pix_format.sizeimage); 1036 1037 buf[4] = 0; 3. Condition debug > 0, taking true branch. 1038 dprintk("outFOURCC=%s\n", fourcc2str(dev->pix_format.pixelformat, buf)); 1039 4. Condition ret < 0, taking false branch. 1040 if (ret < 0) 1041 return ret; 1042 5. Condition !dev->ready_for_capture, taking true branch. 1043 if (!dev->ready_for_capture) { 1044 dev->buffer_size = PAGE_ALIGN(dev->pix_format.sizeimage); 1045 fmt->fmt.pix.sizeimage = dev->buffer_size; CID 114125 (#1 of 1): Unchecked return value (CHECKED_RETURN) 6. check_return: Calling allocate_buffers without checking return value (as is done elsewhere 3 out of 5 times). 1046 allocate_buffers(dev); 1047 } 1048 return ret; 1049} Signed-off-by: Tim Gardner <tim.gardner@canonical.com> (cherry picked from commit b3f1f66) Signed-off-by: You-Sheng Yang <vicamo@gmail.com> Gbp-Pq: Name 0011-v4l2loopback.c-Fix-unchecked-return-value-in-vidioc_.patch
umlaeute
pushed a commit
that referenced
this issue
Aug 4, 2022
Coverity found a possible NULL dereference after NULL check. CID 114122 (#1 of 1): Dereference after null check (FORWARD_NULL) 5. var_deref_op: Dereferencing null pointer dev. Signed-off-by: Tim Gardner <tim.gardner@canonical.com> (cherry picked from commit fc85f86) Signed-off-by: You-Sheng Yang <vicamo@gmail.com> Gbp-Pq: Name 0013-v4l2loopback.c-NULL-dereference-in-free_buffers.patch
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
with GStreamer you currently need the "gst-v4l2loopback" element, rather than being able to directly use "v4l2sink".
The text was updated successfully, but these errors were encountered: