Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gstreamer v4l2sink support #1

Closed
umlaeute opened this issue Oct 1, 2010 · 1 comment
Closed

gstreamer v4l2sink support #1

umlaeute opened this issue Oct 1, 2010 · 1 comment

Comments

@umlaeute
Copy link
Owner

umlaeute commented Oct 1, 2010

with GStreamer you currently need the "gst-v4l2loopback" element, rather than being able to directly use "v4l2sink".
@umlaeute
Copy link
Owner Author

no longer true!
revent v4l2loopback works directly with the v4l2sink element!

@umlaeute umlaeute mentioned this issue Dec 5, 2011
Closed
@0-1 0-1 mentioned this issue Mar 23, 2012
Closed
@bheemanadhuni bheemanadhuni mentioned this issue Nov 17, 2014
Closed
@umlaeute umlaeute mentioned this issue Apr 3, 2016
Closed
@kclim2 kclim2 mentioned this issue Feb 15, 2017
Closed
@Witiko Witiko mentioned this issue Mar 12, 2017
Closed
@umlaeute umlaeute mentioned this issue Mar 18, 2017
Closed
@ashwinprasadme ashwinprasadme mentioned this issue Apr 8, 2017
Closed
@HappyTetrahedron HappyTetrahedron mentioned this issue Apr 20, 2017
Closed
@ashwinprasadme ashwinprasadme mentioned this issue Apr 27, 2017
Closed
@redragonx redragonx mentioned this issue Apr 27, 2017
Closed
@jensJJ jensJJ mentioned this issue Nov 30, 2017
Closed
@Jakob-S Jakob-S mentioned this issue Dec 29, 2017
Closed
@golgobot golgobot mentioned this issue Mar 2, 2018
Closed
@lddd lddd mentioned this issue Mar 28, 2018
Closed
@ROBERT-MCDOWELL ROBERT-MCDOWELL mentioned this issue Nov 16, 2018
Closed
@benlemond benlemond mentioned this issue Jan 17, 2019
Closed
This was referenced Jan 23, 2019
Open
Merged
@MuradMathematics MuradMathematics mentioned this issue Mar 31, 2019
Closed
@benlemond benlemond mentioned this issue Apr 17, 2019
Open
@MichaelDenczek MichaelDenczek mentioned this issue May 15, 2019
Open
@allsey87 allsey87 mentioned this issue Oct 11, 2019
Open
@corinnespi corinnespi mentioned this issue Oct 14, 2019
Closed
@pokebox pokebox mentioned this issue Mar 16, 2020
Closed
@RioChan RioChan mentioned this issue Mar 18, 2020
Closed
@colin-adams colin-adams mentioned this issue Mar 21, 2020
Closed
@drmichaeljgruber drmichaeljgruber mentioned this issue Mar 30, 2020
Closed
@vince7lf vince7lf mentioned this issue Mar 31, 2020
Closed
@Palando Palando mentioned this issue Apr 7, 2020
Closed
@divinitus divinitus mentioned this issue Apr 9, 2020
Closed
@marcusmueller marcusmueller mentioned this issue Apr 13, 2020
Closed
@jeroenpeeters jeroenpeeters mentioned this issue Apr 21, 2020
Closed
@agturcz agturcz mentioned this issue May 7, 2020
Closed
@feydreva feydreva mentioned this issue May 16, 2020
Closed
@willymacoy willymacoy mentioned this issue May 29, 2020
Closed
@archenemies archenemies mentioned this issue Jun 4, 2020
Closed
@DanielPrjct DanielPrjct mentioned this issue Jun 26, 2020
Closed
@MarioMey MarioMey mentioned this issue Aug 14, 2020
Open
@RokerHRO RokerHRO mentioned this issue Nov 2, 2020
Open
rtg-canonical added a commit to rtg-canonical/v4l2loopback that referenced this issue May 27, 2021
@rtg-canonical
v4l2loopback.c: Fix unchecked return value in vidioc_s_fmt_out()
ee32263 
Coverity detected an unchecked return code:

1025static int vidioc_s_fmt_out(struct file *file, void *priv, struct v4l2_format *fmt)
1026{
1027        struct v4l2_loopback_device *dev;
1028        char buf[5];
1029        int ret;
    	1. Condition debug > 1, taking true branch.
1030        MARK();
1031
1032        dev = v4l2loopback_getdevice(file);
1033        ret = vidioc_try_fmt_out(file, priv, fmt);
1034
    	2. Condition debug > 0, taking true branch.
1035        dprintk("s_fmt_out(%d) %d...%d\n", ret, dev->ready_for_capture, dev->pix_format.sizeimage);
1036
1037        buf[4] = 0;
    	3. Condition debug > 0, taking true branch.
1038        dprintk("outFOURCC=%s\n", fourcc2str(dev->pix_format.pixelformat, buf));
1039
    	4. Condition ret < 0, taking false branch.
1040        if (ret < 0)
1041                return ret;
1042
    	5. Condition !dev->ready_for_capture, taking true branch.
1043        if (!dev->ready_for_capture) {
1044                dev->buffer_size = PAGE_ALIGN(dev->pix_format.sizeimage);
1045                fmt->fmt.pix.sizeimage = dev->buffer_size;

CID 114125 (umlaeute#1 of 1): Unchecked return value (CHECKED_RETURN)
6. check_return: Calling allocate_buffers without checking return value (as is done elsewhere 3 out of 5 times).
1046                allocate_buffers(dev);
1047        }
1048        return ret;
1049}

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
@rtg-canonical rtg-canonical mentioned this issue May 27, 2021
Closed
rtg-canonical added a commit to rtg-canonical/v4l2loopback that referenced this issue May 27, 2021
@rtg-canonical
v4l2loopback.c: NULL dereference in free_buffers()
1d246ae 
Coverity found a possible NULL dereference after NULL check.

CID 114122 (umlaeute#1 of 1): Dereference after null check (FORWARD_NULL)
5. var_deref_op: Dereferencing null pointer dev.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
rtg-canonical added a commit to rtg-canonical/v4l2loopback that referenced this issue May 27, 2021
@rtg-canonical
v4l2loopback.c: NULL dereference in free_buffers()
df67bfc 
Coverity found a possible NULL dereference after NULL check.

CID 114122 (umlaeute#1 of 1): Dereference after null check (FORWARD_NULL)
5. var_deref_op: Dereferencing null pointer dev.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
@rtg-canonical rtg-canonical mentioned this issue May 27, 2021
Closed
umlaeute pushed a commit that referenced this issue Jun 1, 2021
@rtg-canonical @umlaeute
v4l2loopback.c: Fix unchecked return value in vidioc_s_fmt_out()
b3f1f66 
Coverity detected an unchecked return code:

1025static int vidioc_s_fmt_out(struct file *file, void *priv, struct v4l2_format *fmt)
1026{
1027        struct v4l2_loopback_device *dev;
1028        char buf[5];
1029        int ret;
    	1. Condition debug > 1, taking true branch.
1030        MARK();
1031
1032        dev = v4l2loopback_getdevice(file);
1033        ret = vidioc_try_fmt_out(file, priv, fmt);
1034
    	2. Condition debug > 0, taking true branch.
1035        dprintk("s_fmt_out(%d) %d...%d\n", ret, dev->ready_for_capture, dev->pix_format.sizeimage);
1036
1037        buf[4] = 0;
    	3. Condition debug > 0, taking true branch.
1038        dprintk("outFOURCC=%s\n", fourcc2str(dev->pix_format.pixelformat, buf));
1039
    	4. Condition ret < 0, taking false branch.
1040        if (ret < 0)
1041                return ret;
1042
    	5. Condition !dev->ready_for_capture, taking true branch.
1043        if (!dev->ready_for_capture) {
1044                dev->buffer_size = PAGE_ALIGN(dev->pix_format.sizeimage);
1045                fmt->fmt.pix.sizeimage = dev->buffer_size;

CID 114125 (#1 of 1): Unchecked return value (CHECKED_RETURN)
6. check_return: Calling allocate_buffers without checking return value (as is done elsewhere 3 out of 5 times).
1046                allocate_buffers(dev);
1047        }
1048        return ret;
1049}

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
umlaeute pushed a commit that referenced this issue Jun 1, 2021
@rtg-canonical @umlaeute
v4l2loopback.c: NULL dereference in free_buffers()
fc85f86 
Coverity found a possible NULL dereference after NULL check.

CID 114122 (#1 of 1): Dereference after null check (FORWARD_NULL)
5. var_deref_op: Dereferencing null pointer dev.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
umlaeute pushed a commit that referenced this issue Aug 4, 2022
@rtg-canonical @umlaeute
v4l2loopback.c: Fix unchecked return value in vidioc_s_fmt_out()
bff11c1 
Coverity detected an unchecked return code:

1025static int vidioc_s_fmt_out(struct file *file, void *priv, struct v4l2_format *fmt)
1026{
1027        struct v4l2_loopback_device *dev;
1028        char buf[5];
1029        int ret;
    	1. Condition debug > 1, taking true branch.
1030        MARK();
1031
1032        dev = v4l2loopback_getdevice(file);
1033        ret = vidioc_try_fmt_out(file, priv, fmt);
1034
    	2. Condition debug > 0, taking true branch.
1035        dprintk("s_fmt_out(%d) %d...%d\n", ret, dev->ready_for_capture, dev->pix_format.sizeimage);
1036
1037        buf[4] = 0;
    	3. Condition debug > 0, taking true branch.
1038        dprintk("outFOURCC=%s\n", fourcc2str(dev->pix_format.pixelformat, buf));
1039
    	4. Condition ret < 0, taking false branch.
1040        if (ret < 0)
1041                return ret;
1042
    	5. Condition !dev->ready_for_capture, taking true branch.
1043        if (!dev->ready_for_capture) {
1044                dev->buffer_size = PAGE_ALIGN(dev->pix_format.sizeimage);
1045                fmt->fmt.pix.sizeimage = dev->buffer_size;

CID 114125 (#1 of 1): Unchecked return value (CHECKED_RETURN)
6. check_return: Calling allocate_buffers without checking return value (as is done elsewhere 3 out of 5 times).
1046                allocate_buffers(dev);
1047        }
1048        return ret;
1049}

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
(cherry picked from commit b3f1f66)
Signed-off-by: You-Sheng Yang <vicamo@gmail.com>

Gbp-Pq: Name 0011-v4l2loopback.c-Fix-unchecked-return-value-in-vidioc_.patch
umlaeute pushed a commit that referenced this issue Aug 4, 2022
@rtg-canonical @umlaeute
v4l2loopback.c: NULL dereference in free_buffers()
b434b7b 
Coverity found a possible NULL dereference after NULL check.

CID 114122 (#1 of 1): Dereference after null check (FORWARD_NULL)
5. var_deref_op: Dereferencing null pointer dev.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
(cherry picked from commit fc85f86)
Signed-off-by: You-Sheng Yang <vicamo@gmail.com>

Gbp-Pq: Name 0013-v4l2loopback.c-NULL-dereference-in-free_buffers.patch
@luigirizzo luigirizzo mentioned this issue Sep 15, 2022
Closed
@John11141 John11141 mentioned this issue May 30, 2023
Closed
@stephematician stephematician mentioned this issue Jun 23, 2023
Open
@v4u6h4n v4u6h4n mentioned this issue Apr 26, 2024
Closed
1 task
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@umlaeute