Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the HTTP client body in tests, add lint #1003

Merged
merged 1 commit into from
May 13, 2021
Merged

Close the HTTP client body in tests, add lint #1003

merged 1 commit into from
May 13, 2021

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented May 13, 2021 •
edited
Loading

Found few places which were not properly closed, so enabled the linter to detect these.

@paskal paskal requested a review from umputun May 13, 2021 21:06
@coveralls
Copy link

coveralls commented May 13, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 840339580

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 83.6%
Totals Coverage Status
Change from base Build 840006084: 0.003%
Covered Lines: 5388
Relevant Lines: 6445
💛 - Coveralls

@paskal paskal changed the title close the body in rest_private_test Close the HTTP client body in tests, add lint May 13, 2021
@umputun umputun merged commit 63220f3 into master May 13, 2021
@umputun umputun deleted the paskal/close_body branch May 13, 2021 22:59
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun Awaiting requested review from umputun umputun is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@paskal @coveralls @umputun