Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover all auth providers with tests, clean up env #1023

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented May 24, 2021

Add all auth providers to tests for consistency, reset all variables containing sensitive data on remark42 start (a couple were missing). Changes were done in #1022, but I thought it makes sense to merge them separately.

@paskal paskal requested a review from umputun May 24, 2021 18:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 872358470

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 83.663%

Files with Coverage Reduction New Missed Lines %
backend/app/notify/notify.go 2 94.29%
Totals Coverage Status
Change from base Build 872139555: 0.09%
Covered Lines: 5413
Relevant Lines: 6470

💛 - Coveralls

@umputun umputun merged commit 4f2db3c into master May 24, 2021
@umputun umputun deleted the paskal/auth_fixes branch May 24, 2021 22:15
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants