Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Remark42 with Gatsby (documentation) #1222

Merged
merged 8 commits into from
Jan 15, 2022
Merged

Integrating Remark42 with Gatsby (documentation) #1222

merged 8 commits into from
Jan 15, 2022

Conversation

elmaester
Copy link
Contributor

As per request from @paskal here, adding some documentation about integrating Remark42 with Gatsby

@BenRoe
Copy link
Contributor

BenRoe commented Jan 11, 2022

Will test it tomorrow and will give some feedback.

@BenRoe
Copy link
Contributor

BenRoe commented Jan 12, 2022

I am not sure if the semicolon syntax should be used, because it's easier to read without. Official GatsbyJS repo do not use the semicolon.

@elmaester i open a pr on your repo with some small typo fixes.

@elmaester
Copy link
Contributor Author

elmaester commented Jan 12, 2022

Sure, approved, thank you

@paskal
Copy link
Collaborator

paskal commented Jan 13, 2022

Thanks a lot for the documentation! The only thing missing is an entry for it in nav.json, can you please add it as well?

@elmaester
Copy link
Contributor Author

@paskal It is done 😃

@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@umputun umputun merged commit a748e26 into umputun:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants