Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent code execution from the query #1315

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Prevent code execution from the query #1315

merged 2 commits into from
Apr 10, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Apr 9, 2022

No description provided.

@akellbl4 akellbl4 requested a review from Mavrin April 9, 2022 23:09
@akellbl4 akellbl4 requested a review from umputun as a code owner April 9, 2022 23:09
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #1315 (2f97a1f) into master (5ed7f27) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
+ Coverage   48.46%   48.68%   +0.21%     
==========================================
  Files         136      136              
  Lines        3060     3073      +13     
  Branches      686      689       +3     
==========================================
+ Hits         1483     1496      +13     
  Misses       1566     1566              
  Partials       11       11              
Impacted Files Coverage Δ
frontend/app/common/constants.config.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eac76c...2f97a1f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.02 KB (+6.6% 🔺)
public/remark.mjs 67.55 KB (+0.18% 🔺)
public/remark.css 8.25 KB (-0.02% 🔽)
public/last-comments.mjs 30.37 KB (+0.38% 🔺)
public/last-comments.css 3.74 KB (-0.03% 🔽)
public/deleteme.mjs 9.92 KB (+1.34% 🔺)
public/counter.mjs 749 B (+24.63% 🔺)

@akellbl4 akellbl4 marked this pull request as draft April 9, 2022 23:12
@akellbl4 akellbl4 marked this pull request as ready for review April 9, 2022 23:48
@umputun umputun merged commit 5de9544 into master Apr 10, 2022
@umputun umputun deleted the prevent-query-xss branch April 10, 2022 20:35
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants