Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default system font #1317

Merged
merged 1 commit into from
Apr 10, 2022
Merged

use default system font #1317

merged 1 commit into from
Apr 10, 2022

Conversation

akellbl4
Copy link
Collaborator

Resolves #1268

  • changes base font to system font
  • adjustments for comment styles accordingly to the new font
  • adjustments for comment action button styles accordingly to the new font
  • use remark.css for all of the widgets because it contains all of the necessary fonts and can be cached one time. that means no need to load other chunks and increase the amount of code for download

CleanShot 2022-04-09 at 18 00 36@2x

CleanShot 2022-04-09 at 18 00 29@2x

@akellbl4 akellbl4 requested review from paskal and Mavrin April 10, 2022 01:19
@akellbl4 akellbl4 requested a review from umputun as a code owner April 10, 2022 01:19
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #1317 (cf769b9) into master (5ed7f27) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   48.46%   48.46%   -0.01%     
==========================================
  Files         136      136              
  Lines        3060     3058       -2     
  Branches      686      686              
==========================================
- Hits         1483     1482       -1     
+ Misses       1566     1565       -1     
  Partials       11       11              
Impacted Files Coverage Δ
...end/app/components/list-comments/list-comments.tsx 0.00% <ø> (ø)
frontend/app/last-comments.tsx 0.00% <0.00%> (ø)
frontend/app/components/comment/comment.tsx 64.83% <50.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89c9a1...cf769b9. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 10, 2022

size-limit report 📦

Path Size
public/embed.mjs 1.89 KB (0%)
public/remark.mjs 67.44 KB (+0.03% 🔺)
public/remark.css 8.28 KB (+0.35% 🔺)
public/last-comments.mjs 30.25 KB (-0.02% 🔽)
public/last-comments.css 0 B (-100% 🔽)
public/deleteme.mjs 9.79 KB (0%)
public/counter.mjs 601 B (0%)

@umputun umputun merged commit 145b4c4 into master Apr 10, 2022
@umputun umputun deleted the update-font branch April 10, 2022 20:34
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PT Sans as main font OR include it
4 participants