Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite vote component #1323

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Rewrite vote component #1323

merged 2 commits into from
Apr 13, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Apr 12, 2022

  • hide arrows instead of showing error messages
  • update look and feel
  • show errors on voting in tooltip

CleanShot 2022-04-12 at 19 43 40@2x

CleanShot 2022-04-12 at 19 43 25@2x

All states

Voting error:
CleanShot 2022-04-12 at 19 48 25@2x

Upvote hover:
CleanShot 2022-04-12 at 19 44 07@2x

Downvote hover:
CleanShot 2022-04-12 at 19 44 13@2x

Voting block hover:
CleanShot 2022-04-12 at 19 44 17@2x

Upvoted:
CleanShot 2022-04-12 at 19 44 25@2x

Downvoted:
CleanShot 2022-04-12 at 19 44 32@2x

@akellbl4 akellbl4 force-pushed the vote-component branch 3 times, most recently from 7f1fd2f to cf4d717 Compare April 12, 2022 03:17
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 487 ms (+28.51% 🔺) 528 ms
public/remark.mjs 65.81 KB (-0.32% 🔽) 1.4 s (-0.32% 🔽) 489 ms (-36.26% 🔽) 1.9 s
public/remark.css 8.29 KB (+0.43% 🔺) 166 ms (+0.43% 🔺) 0 ms (+100% 🔺) 166 ms
public/last-comments.mjs 31.79 KB (+2.35% 🔺) 636 ms (+2.35% 🔺) 690 ms (+55.94% 🔺) 1.4 s
public/deleteme.mjs 9.92 KB (0%) 199 ms (0%) 373 ms (+13.9% 🔺) 571 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 366 ms (+21.75% 🔺) 381 ms

@akellbl4 akellbl4 force-pushed the vote-component branch 5 times, most recently from 7a3cc50 to bcd0018 Compare April 12, 2022 06:39
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1323 (acb7ffc) into master (a290d90) will increase coverage by 0.55%.
The diff coverage is 86.04%.

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
+ Coverage   50.03%   50.59%   +0.55%     
==========================================
  Files         137      139       +2     
  Lines        3046     3046              
  Branches      695      692       -3     
==========================================
+ Hits         1524     1541      +17     
+ Misses       1506     1490      -16     
+ Partials       16       15       -1     
Impacted Files Coverage Δ
...ntend/app/components/comment/connected-comment.tsx 0.00% <0.00%> (ø)
frontend/app/components/comment/styles.ts 100.00% <ø> (ø)
frontend/app/components/icons/arrow.tsx 100.00% <ø> (ø)
frontend/app/store/comments/reducers.ts 0.00% <0.00%> (ø)
frontend/app/store/comments/actions.ts 55.07% <28.57%> (+2.21%) ⬆️
frontend/app/common/api.ts 72.72% <50.00%> (ø)
frontend/app/components/tooltip/tooltip.tsx 92.30% <92.30%> (ø)
frontend/app/components/comment/comment-votes.tsx 95.65% <95.65%> (ø)
frontend/app/components/comment/comment.tsx 65.05% <100.00%> (-0.04%) ⬇️
frontend/app/components/tooltip/index.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a290d90...acb7ffc. Read the comment docs.

@akellbl4 akellbl4 force-pushed the vote-component branch 2 times, most recently from b46b6c7 to 6ee80a3 Compare April 12, 2022 21:57
@akellbl4 akellbl4 requested a review from Mavrin April 12, 2022 21:58
@akellbl4 akellbl4 force-pushed the vote-component branch 2 times, most recently from bc501b6 to 79b3302 Compare April 13, 2022 03:36
@akellbl4 akellbl4 marked this pull request as ready for review April 13, 2022 03:36
@akellbl4 akellbl4 requested a review from umputun as a code owner April 13, 2022 03:36
@akellbl4 akellbl4 force-pushed the vote-component branch 2 times, most recently from ba689d1 to 8a7cb44 Compare April 13, 2022 03:52
@umputun
Copy link
Owner

umputun commented Apr 13, 2022

this one is conflicting

Mavrin
Mavrin previously approved these changes Apr 13, 2022
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants