Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iframe height update on slow connection #1407

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

akellbl4
Copy link
Collaborator

Resolves #1340

Update the iframe's height when the image from a comment is loaded.

@akellbl4 akellbl4 requested a review from umputun as a code owner July 10, 2022 20:43
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #1407 (88514e5) into master (9971698) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   57.88%   57.82%   -0.07%     
==========================================
  Files         130      130              
  Lines        2885     2888       +3     
  Branches      741      742       +1     
==========================================
  Hits         1670     1670              
- Misses       1211     1214       +3     
  Partials        4        4              
Impacted Files Coverage Δ
frontend/app/components/root/root.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f96a0e...88514e5. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 355 ms (+151.17% 🔺) 396 ms
public/remark.mjs 70.86 KB (+0.06% 🔺) 1.5 s (+0.06% 🔺) 801 ms (-3.52% 🔽) 2.3 s
public/remark.css 8.2 KB (0%) 165 ms (0%) 0 ms (+100% 🔺) 165 ms
public/last-comments.mjs 35.62 KB (0%) 713 ms (0%) 741 ms (+43.32% 🔺) 1.5 s
public/last-comments.css 3.79 KB (0%) 76 ms (0%) 0 ms (+100% 🔺) 76 ms
public/deleteme.mjs 10.01 KB (0%) 201 ms (0%) 339 ms (-25.92% 🔽) 539 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 506 ms (+52.81% 🔺) 521 ms

@umputun umputun merged commit aac6af4 into master Jul 11, 2022
@umputun umputun deleted the fix-1340/update-iframe-height branch July 11, 2022 17:54
@paskal paskal added this to the v1.10.2 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect markup when images load not really fast
4 participants