add the ability to set the JWS aud per site_id #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this option, the aud is ignored. It works only with RPC admin storage. The shared key returned for all requests with the default shared admin storage, so enabling that option does not affect it.
paskal
force-pushed
the
paskal/aud_per_site
branch
from
f5c31f4
to
f61cfc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this option, the aud is ignored.
It works only with RPC admin storage.
The shared key returned for all requests with the default shared admin storage, so enabling that option does not affect it.
Resolves #1519, cc @daniloarcidiacono.
I think the better alternative would be enabling it for everyone, as it doesn't affect the behaviour of the shared storage and changes the calls to RPC admin storage (previously, it was called with
aud=="ignore") but makes things more predictable for RPC storage implementer out of the box.