Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix no footer param #1567

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix: fix no footer param #1567

merged 2 commits into from
Jan 10, 2023

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jan 8, 2023

Pull the param from query and transform from string to boolean.

btw I don't know why do we have remark_config inside the iframe which is bad.

@akellbl4 akellbl4 requested a review from Mavrin January 8, 2023 18:03
@akellbl4 akellbl4 requested a review from umputun as a code owner January 8, 2023 18:03
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 62.35% // Head: 58.63% // Decreases project coverage by -3.71% ⚠️

Coverage data is based on head (bf818fb) compared to base (6ac7503).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
- Coverage   62.35%   58.63%   -3.72%     
==========================================
  Files         139      128      -11     
  Lines        3421     2877     -544     
  Branches      803      730      -73     
==========================================
- Hits         2133     1687     -446     
+ Misses       1090     1065      -25     
+ Partials      198      125      -73     
Impacted Files Coverage Δ
...rontend/apps/remark42/app/components/root/root.tsx 0.00% <0.00%> (ø)
...nd/apps/remark42/app/components/auth/auth.hooks.ts 89.18% <66.66%> (-1.84%) ⬇️
frontend/apps/remark42/app/common/settings.ts 90.47% <100.00%> (+0.47%) ⬆️
frontend/apps/remark42/app/utils/post-message.ts 66.66% <100.00%> (+16.66%) ⬆️
frontend/apps/remark42/app/common/cookies.ts 21.05% <0.00%> (-2.76%) ⬇️
frontend/apps/remark42/app/common/api.ts 72.09% <0.00%> (-0.64%) ⬇️
frontend/apps/remark42/app/common/fetcher.ts 94.82% <0.00%> (-0.09%) ⬇️
frontend/apps/remark42/app/common/types.ts 100.00% <0.00%> (ø)
frontend/apps/remark42/app/hooks/useTheme.ts 100.00% <0.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.67 KB (-0.02% 🔽)
public/remark.css 8.12 KB (0%)
public/last-comments.mjs 35.63 KB (+0.04% 🔺)
public/last-comments.css 3.72 KB (-0.03% 🔽)
public/deleteme.mjs 12.05 KB (+0.07% 🔺)
public/counter.mjs 749 B (0%)

Mavrin
Mavrin previously approved these changes Jan 10, 2023
@umputun umputun merged commit 0169582 into master Jan 10, 2023
@umputun umputun deleted the akellbl4/fix-nofooter branch January 10, 2023 17:27
@paskal paskal added this to the v1.11.3 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants