Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #31: Replace separate UI with the embedded HTMX based #32

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Issue #31: Replace separate UI with the embedded HTMX based #32

merged 3 commits into from
Oct 8, 2023

Conversation

oneils
Copy link
Contributor

@oneils oneils commented Oct 1, 2023

The old UI will be removed in a separate PR

@umputun umputun self-requested a review October 1, 2023 18:07
umputun
umputun requested changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid job, makes sense and easy to read. A few small suggestions

backend/app/server/server.go Outdated Show resolved Hide resolved
backend/app/server/server.go Outdated Show resolved Hide resolved
backend/app/server/templates.go Outdated Show resolved Hide resolved
backend/app/server/server.go Outdated Show resolved Hide resolved
backend/app/server/templates.go Outdated Show resolved Hide resolved
@oneils
Issue umputun#31: Replace separate UI with the embedded HTMX based
69df06d 
   - updated Docker files to build the app correctly
umputun
umputun approved these changes Oct 8, 2023
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit 469d0b8 into umputun:master Oct 8, 2023
1 check passed
@umputun umputun mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oneils @umputun