Multiple task cli option #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umputun
requested changes
Jul 25, 2023
| @@ -198,7 +200,10 @@ func runAdHoc(ctx context.Context, targets []string, r *runner.Process) error { | |||
|
|
|||
| // runGen generates a destination report for the task's targets | |||
| func runGen(opts options, r *runner.Process) (err error) { | |||
| targets := targetsForTask(opts.Targets, opts.TaskName, r.Playbook) | |||
| var targets []string | |||
| for _, taskName := range opts.TaskNames { | |||
There was a problem hiding this comment.
probably this will cause duplicated targets in the final list. I'm not sure how bad the end result is going to be but deduplication of the result slice sounds like the right thing to do
There was a problem hiding this comment.
Actually, it causes duplicates in the targets list. I've updated the code and added a test to cover the case.
bakurin
force-pushed
the
multiple-task-cli-option
branch
from
cc21f8c
to
c862a41
Compare
ifraixedes
reviewed
Jul 26, 2023
|
LGTM, can you pls rebase/squash into a single commit, and I'll merge |
bakurin
force-pushed
the
multiple-task-cli-option
branch
from
c5a744c
to
a691c33
Compare
|
All changes are squashed and rebased on the latest master. |
umputun
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multiple
--taskCLI option requested in #131