-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to enable agent forwarding #187
Merged
umputun
merged 3 commits into
umputun:master
from
NikitaVasiliev:add_option_forward_agent
Apr 7, 2024
Merged
add option to enable agent forwarding #187
umputun
merged 3 commits into
umputun:master
from
NikitaVasiliev:add_option_forward_agent
Apr 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you. Here are a few minor corrections:
|
NikitaVasiliev
force-pushed
the
add_option_forward_agent
branch
2 times, most recently
from
March 25, 2024 17:22
550bc61
to
cbd03b7
Compare
There was indeed a problem. The simple use of a WaitGroup led to a deadlock because some goroutines were stuck at connections. I had to close those connections as well. |
NikitaVasiliev
force-pushed
the
add_option_forward_agent
branch
2 times, most recently
from
March 25, 2024 17:54
8f7789a
to
3ce497b
Compare
Pull Request Test Coverage Report for Build 8591076724Details
💛 - Coveralls |
A few problems:
|
NikitaVasiliev
force-pushed
the
add_option_forward_agent
branch
from
March 31, 2024 09:40
3ce497b
to
326de23
Compare
|
LGTM, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the forward-ssh-agent option, allowing users to leverage SSH agent forwarding when executing commands on remote hosts. This facilitates secure authentication by forwarding connections from a local authentication agent, such as ssh-agent, to the remote host. It’s particularly useful in environments where direct SSH access needs to be secured and simplified without exposing private key material.
If it isn't needed or doesn't fit the project's direction, feel free to decline this PR.