Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only fallback to text on error #14

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix: only fallback to text on error #14

merged 2 commits into from
Jan 29, 2024

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jan 29, 2024

No description provided.

@JounQin JounQin added the bug Something isn't working label Jan 29, 2024
@JounQin JounQin self-assigned this Jan 29, 2024
Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: 512f640

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 29, 2024

size-limit report 📦

Path Size
lib/index.js 935 B (+1.75% 🔺)

test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
test/utils.spec.ts Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (dba61f1) 96.38% compared to head (512f640) 92.22%.

Files Patch % Lines
src/utils.ts 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   96.38%   92.22%   -4.17%     
==========================================
  Files           3        3              
  Lines          83       90       +7     
  Branches       23       27       +4     
==========================================
+ Hits           80       83       +3     
- Misses          3        7       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin JounQin merged commit 5e1cd70 into main Jan 29, 2024
22 of 24 checks passed
@JounQin JounQin deleted the fix/fallback branch January 29, 2024 09:30
@JounQin JounQin mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant