Normalize User / Project Id Types

[cstrnt]

Currently we have some ids stored as numbers, some as strings (see here for more details: #49 (comment))

Those should be normalized so we don't have to do conversions anymore when comparing them.

Also the current conversions should be removed

[skushagra9]

should I change it for providers like github, gitlab also ?

[McPizza0]

should I change it for providers like github, gitlab also ?

this is unrelated to the issue

[skushagra9]

oh, I see, I was thinking to change the types

[McPizza0]

the source of the issue:
when we insert a new db row, the response.insertId is a string so we need to cast it to a number by preceding it with a +
throughout the app/db we use number based ids for all internal linking and logic

there was an issue where the id column would be returned as a string instead of a number in db queries
so i got into the bad habit of always casting id columns to numbers

the fix: look at all db responses (from DB and from Cache storages), check the type of the returned id and remove the casting if it is no longer needed

a regex search across the codebase \+.*\.id shows there are 75 results
each one needs its type checked and the casting to be removed

full testing of the app will need to be conducted after to ensure there arnt any lingering issues

[skushagra9]

Thanks, got it

[skushagra9]

@McPizza0 , If you aren't working on this issue, can I work on this please ?

[McPizza0]

sorry @skushagra9 this issue requires a lot of attention and testing

[skushagra9]

Ok