Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mailtools): add playground, refactor signature extractions #122

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

McPizza0
Copy link
Member

@McPizza0 McPizza0 commented Mar 4, 2024

What does this PR do?

Fixes #120 #121

This pr introduces a playground for local testing of the mailtools package

we have also split out the signature parser from the quotations parser
it now returns the parsed signatures in plain text and html

and the cleanstyles function can now accept an array of styles to remove, or if set to true will remove default styles

NOT DONE:
tests were not added for the new stuff...

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member

@BlankParticle BlankParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good, I didn't have time to look at everything else as I am busy with recovery codes stuff. I hope you have tested everything yourself.
Other than that its ok to merge. I will take care of updating the tests later

packages/mailtools/src/removeSignatures.ts Outdated Show resolved Hide resolved
@McPizza0 McPizza0 merged commit 157b8a1 into main Mar 4, 2024
2 checks passed
@McPizza0 McPizza0 deleted the feat/mailtools-playground branch March 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(mailtools): improve signature parsing
2 participants